Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sheet-ui): make the default font family and font size correct #1827

Merged
merged 4 commits into from
Apr 12, 2024
Merged

fix(sheet-ui): make the default font family and font size correct #1827

merged 4 commits into from
Apr 12, 2024

Conversation

karlsbeard
Copy link
Contributor

@karlsbeard karlsbeard commented Apr 8, 2024 •
edited by jikkai
Loading

  • fix: correct the default font size
  • fix: correct the default font family

close #1655
close #588

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Apr 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 7.89474% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 29.56%. Comparing base (fc4cc4c) to head (d7dc123).
Report is 35 commits behind head on dev.

Files Patch % Lines
packages/sheets-ui/src/controllers/menu/menu.ts 7.89% 70 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1827      +/-   ##
==========================================
- Coverage   29.68%   29.56%   -0.13%     
==========================================
  Files        1158     1163       +5     
  Lines       62778    63200     +422     
  Branches    13177    13298     +121     
==========================================
+ Hits        18634    18683      +49     
- Misses      44144    44517     +373

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karlsbeard karlsbeard marked this pull request as ready for review April 9, 2024 10:00
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 9, 2024
jikkai
jikkai approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jikkai jikkai removed the qa:untested This PR is ready to be tested label Apr 12, 2024
@jikkai jikkai merged commit ea18b99 into dev Apr 12, 2024
8 checks passed
@jikkai jikkai deleted the fix-1655 branch April 12, 2024 04:05
Jocs pushed a commit that referenced this pull request Apr 13, 2024
@karlsbeard @Jocs
fix(sheet-ui): make the default font family and font size correct (#1827
1ff20f5 
)

* fix(sheet-ui): make the default font family and font size correct

* fix(sheet): fix the set-style test of sheet

* fix(sheet-ui): fix the default style of the initial selected cell

* fix: remove unnecessary change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jikkai jikkai jikkai approved these changes

@Jocs Jocs Jocs approved these changes

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev is a code owner

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@karlsbeard @Jocs @jikkai